On Fri, 21 Mar 2025 at 15:49, Cédric Le Goater <c...@redhat.com> wrote:
> So you mean open coding :
> if (migration_is_running()) {
> migration_file_set_error(ret, errp);
> }
> ?
* Yes.
> Yes. I think it is a good idea to limit proliferation of this wrapper.
> Ideally, we wouldn't need to use migration_file_set_error() at all but
> we still have some callback routines not taking an Error **parameter
> unfortunately.
>
> IOMMU notifiers :
>
> vfio_iommu_map_notify
> vfio_iommu_map_dirty_notify
>
> MemoryListener handlers :
>
> vfio_listener_log_global_stop
> vfio_listener_log_sync
>
> I will send a series removing vfio_migration_set_error() to improve
> error reporting in the dirty tracking handlers. This makes sense,
> thanks for reminding me.
Thank you.
---
- Prasad
