On 21/03/2025 11:22, Cédric Le Goater wrote:
> On 3/19/25 13:21, Joao Martins wrote:
>> On 18/03/2025 09:54, Cédric Le Goater wrote:
>>> Rename these routines :
>>>
>>> vfio_devices_all_device_dirty_tracking_started ->
>>> vfio_dirty_tracking_devices_is_started_all
>>> vfio_devices_all_dirty_tracking_started ->
>>> vfio_dirty_tracking_devices_is_started
>>> vfio_devices_all_device_dirty_tracking ->
>>> vfio_dirty_tracking_devices_is_supported
>>> vfio_devices_dma_logging_start ->
>>> vfio_dirty_tracking_devices_dma_logging_start
>>> vfio_devices_dma_logging_stop ->
>>> vfio_dirty_tracking_devices_dma_logging_stop
>>> vfio_devices_query_dirty_bitmap ->
>>> vfio_dirty_tracking_devices_query_dirty_bitmap
>>> vfio_get_dirty_bitmap ->
>>> vfio_dirty_tracking_query_dirty_bitmap
>>>
>>> to better reflect the namespace they belong to.
>>>
>>> Signed-off-by: Cédric Le Goater <c...@redhat.com>
>>
>> The change itself is fine.
>>
>> But on the other hand, it looks relatively long names, no?
>
> I agree.
>
>> I am bit at two minds
>> (as I generally prefer shorter code), but I can't find any alternatives if
>> you
>> really wanna have one namespaces associated with the subsystem:file as a C
>> namespace.
>>
>> Every once and a while me and Avihai use the acronym DPT (Dirty Page
>> Tracking)
>> when talking about this stuff, but it seems a detour from the code style to
>> abbreviate namespaces into acronyms.
>
> I am ok to use a TLA for Dirty Page Tracking. Would DPT statisfy everyone ?
>
It would, but the new version looks shorter so maybe we don't need to go against
style with TLAs.
>>
>> Having said that:
>>
>> Reviewed-by: Joao Martins <joao.m.mart...@oracle.com>
>>
>> P.S. We could also remove 'devices' as the prefix for VF dirty tracking after
>> namespace, and thus drop 'dma logging'. That should put 'start/stop' a little
>> shorter.
>
> Could you please send your proposal as a list, like the commit log does
> and let's discuss.
The idea was :
vfio_dirty_tracking_devices_dma_logging_start ->
vfio_container_dma_logging_start
vfio_dirty_tracking_devices_dma_logging_stop ->
vfio_container_dma_logging_stop
But honestly, doesn't make that much of the difference.
I'll have a look at your v2 hopefully tomorrow or Wednesday on the device dirty
tracking parts and iommufd dirty tracking.
