On Tue, Mar 25, 2025 at 05:06:42PM +0100, Hanna Czenczek wrote: > When exports are created on the command line (with the storage daemon), > errp is going to point to error_fatal. Without ERRP_GUARD, we would > exit immediately when *errp is set, i.e. skip the clean-up code under > the `fail` label. Use ERRP_GUARD so we always run that code. > > As far as I know, this has no actual impact right now[1], but it is > still better to make this right. > > [1] Not cleaning up the mount point is the only thing I can imagine > would be problematic, but that is the last thing we attempt, so if > it fails, it will clean itself up. > > Signed-off-by: Hanna Czenczek <hre...@redhat.com> > --- > block/export/fuse.c | 1 + > 1 file changed, 1 insertion(+)
Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
signature.asc
Description: PGP signature