On Tue, Mar 25, 2025 at 3:36 AM Markus Armbruster <arm...@redhat.com> wrote:
> John Snow <js...@redhat.com> writes: > > > This restores the linting baseline in qapidoc. The order of some imports > > have changed slightly due to configuring isort a little better: isort > > Changed since when / what? > Changed as of this patch. Before, I was running isort directly from the docs/sphinx folder, but now I'm running it from the Python directory with some improved configuration as I explain in this commit: by teaching isort that compat and qapidoc_legacy are local modules, isort decides to arrange them differently. Imports should always go in three sections, in order: 1. Standard library imports 2. Third party imports 3. First party (local) imports Before, it was not, because it does not understand "docs/sphinx" as a local package with local modules - I think it gets confused because of the folder being named "sphinx". Really, I am just explaining why some imports get shuffled around a little bit - the new order is "correct" and the old order was slightly wrong. > > > was having difficulty understanding that "compat" and "qapidoc_legacy" > > were local modules because docs/sphinx "isn't a python package". > > > > Signed-off-by: John Snow <js...@redhat.com> > >
