Re: [PATCH v3 1/3] hw/arm/imx8mp-evk: Fix reference count of SoC object

[Bernhard Beschow]

Am 18. März 2025 20:57:07 UTC schrieb Bernhard Beschow <shen...@gmail.com>:
>TYPE_FSL_IMX8MP is created using object_new(), so must be realized with
>qdev_realize_and_unref() to keep the reference counting intact.
>

Fixes: a4eefc69b237 "hw/arm: Add i.MX 8M Plus EVK board"

>Signed-off-by: Bernhard Beschow <shen...@gmail.com>
>---
> hw/arm/imx8mp-evk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/hw/arm/imx8mp-evk.c b/hw/arm/imx8mp-evk.c
>index e1a7892fd7..e1a21e52f9 100644
>--- a/hw/arm/imx8mp-evk.c
>+++ b/hw/arm/imx8mp-evk.c
>@@ -37,7 +37,7 @@ static void imx8mp_evk_init(MachineState *machine)
>     s = FSL_IMX8MP(object_new(TYPE_FSL_IMX8MP));
>     object_property_add_child(OBJECT(machine), "soc", OBJECT(s));
>     object_property_set_uint(OBJECT(s), "fec1-phy-num", 1, &error_fatal);
>-    qdev_realize(DEVICE(s), NULL, &error_fatal);
>+    qdev_realize_and_unref(DEVICE(s), NULL, &error_fatal);
> 
>     memory_region_add_subregion(get_system_memory(), FSL_IMX8MP_RAM_START,
>                                 machine->ram);