On Mon, Mar 17, 2025 at 05:38:10PM +0100, Paolo Bonzini wrote: > Date: Mon, 17 Mar 2025 17:38:10 +0100 > From: Paolo Bonzini <pbonz...@redhat.com> > Subject: Re: [PATCH 12/17] rust/vmstate: Support version field in vmstate > macros > > On Mon, Mar 17, 2025 at 3:52 PM Zhao Liu <zhao1....@intel.com> wrote: > > Add "version = *" in vmstate macros to help set version_id in > > VMStateField. > > Could it use a ".with_min_version(2)" annotation (or something similar) > instead? >
Ah, thanks! I didn't realize there was already a with_version_id() and didn't understand your design intent, so vmstate_of!(FooC, ptr).with_version_id(2), would have been good enough! There is no need to add this `version` field. Regards, Zhao