Re: [PATCH 3/6] ppc/xive2: Fix logical / bitwise comparison typo

[Cédric Le Goater]

On 3/17/25 06:23, Nicholas Piggin wrote:

The comparison as written is always false (perhaps confusingly, because
the functions/macros are not really booleans but return 0 or the tested
bit value). Change to use logical-and.

Resolves: Coverity CID 1593721
Cc: Cédric Le Goater <c...@redhat.com>
Signed-off-by: Nicholas Piggin <npig...@gmail.com>

Reviewed-by: Cédric Le Goater <c...@redhat.com>

Thanks,

C.

---
  hw/intc/xive2.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/intc/xive2.c b/hw/intc/xive2.c
index 311b42e15d3..7d584dfafaf 100644
--- a/hw/intc/xive2.c
+++ b/hw/intc/xive2.c
@@ -1344,7 +1344,7 @@ static void xive2_router_end_notify(Xive2Router *xrtr, 
uint8_t end_blk,
          return;
      }

- if (xive2_end_is_crowd(&end) & !xive2_end_is_ignore(&end)) {

+    if (xive2_end_is_crowd(&end) && !xive2_end_is_ignore(&end)) {
          qemu_log_mask(LOG_GUEST_ERROR,
                        "XIVE: invalid END, 'crowd' bit requires 'ignore' 
bit\n");
          return;