Am 04.05.2012 18:36, schrieb Paolo Bonzini: > Il 04/05/2012 18:30, Stefan Weil ha scritto: >>> >>> +#define SCSI_DISK_F_REMOVABLE 0 >>> + >> >> ERROR: code indent should never use tabs >> #23: FILE: hw/scsi-disk.c:64: >> +#define SCSI_DISK_F_REMOVABLE^I0$ >> >> total: 1 errors, 0 warnings, 74 lines checked > > Not code indent. > > $ git grep $'^#.*define.*\t' -- \*.c |wc -l > 3244
So? We add missing braces on the lines we touch as well. On the lines I'm touching in my upcoming series I've thus space-converted such tabs. Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg