Clang complains:
clang -O2 -m64 -mcx16
/home/alex/lsrc/qemu.git/tests/tcg/i386/test-i386-adcox.c -o test-i386-adcox
-static
/home/alex/lsrc/qemu.git/tests/tcg/i386/test-i386-adcox.c:32:26: error:
invalid input constraint '0' in asm
: "r" ((REG)-1), "0" (flags), "1" (out_adcx), "2" (out_adox));
^
/home/alex/lsrc/qemu.git/tests/tcg/i386/test-i386-adcox.c:57:26: error:
invalid input constraint '0' in asm
: "r" ((REG)-1), "0" (flags), "1" (out_adcx), "2" (out_adox));
^
2 errors generated.
Pointing out a numbered input constraint can't point to a read/write
output [1]. Convert to a read-only input constraint to allow this.
[1]
https://lists.llvm.org/pipermail/cfe-commits/Week-of-Mon-20101101/036036.html
Suggested-by: Daniel P. Berrangé <berra...@redhat.com>
Reviewed-by: Richard Henderson <richard.hender...@linaro.org>
Signed-off-by: Alex Bennée <alex.ben...@linaro.org>
Message-Id: <20250304222439.2035603-16-alex.ben...@linaro.org>
diff --git a/tests/tcg/i386/test-i386-adcox.c b/tests/tcg/i386/test-i386-adcox.c
index 16169efff8..a717064adb 100644
--- a/tests/tcg/i386/test-i386-adcox.c
+++ b/tests/tcg/i386/test-i386-adcox.c
@@ -29,7 +29,7 @@ void test_adox_adcx(uint32_t in_c, uint32_t in_o, REG
adcx_operand, REG adox_ope
"adcx %3, %1;"
"pushf; pop %0"
: "+r" (flags), "+r" (out_adcx), "+r" (out_adox)
- : "r" ((REG)-1), "0" (flags), "1" (out_adcx), "2" (out_adox));
+ : "r" ((REG) - 1), "0" (flags), "1" (out_adcx), "2" (out_adox));
assert(out_adcx == in_c + adcx_operand - 1);
assert(out_adox == in_o + adox_operand - 1);
@@ -53,8 +53,8 @@ void test_adcx_adox(uint32_t in_c, uint32_t in_o, REG
adcx_operand, REG adox_ope
"adcx %3, %1;"
"adox %3, %2;"
"pushf; pop %0"
- : "+r" (flags), "+r" (out_adcx), "+r" (out_adox)
- : "r" ((REG)-1), "0" (flags), "1" (out_adcx), "2" (out_adox));
+ : "+r"(flags), "+r"(out_adcx), "+r"(out_adox)
+ : "r" ((REG)-1));
assert(out_adcx == in_c + adcx_operand - 1);
assert(out_adox == in_o + adox_operand - 1);
--
2.39.5
