> > Uhm, Christian fix would have the same problem actually if > > virtio-*-pci were to be moved in libhw. IIRC I proposed the > > same change on review and Anthony nacked it on these grounds. > > You could move the alias list to target-dependent code, though. > > Can't we just make the virtio-*-pci variants fail instantiation and > based on that search the list on?
The alias list is used in other places than just instantiation (e.g. -device ?). If it were me I'd just go with Christian's patch; it is conceptually broken, but in the same way as QEMU 1.0 (i.e. relies on virtio-*-pci not being compiled into s390 binaries). A comment will do. Paolo
