On Fri, Mar 7, 2025 at 5:26 AM Markus Armbruster <arm...@redhat.com> wrote:
> John Snow <js...@redhat.com> writes: > > > Adds the .. qapi:event:: directive, object, and :qapi:event:`name` > > cross-referencing role. > > > > Adds the :memb type name: field list syntax for documenting event data > > members. As this syntax and phrasing will be shared with Structs and > > Unions as well, add the field list definition to a shared abstract > > class. > > docs/devel/qapi-code-gen.rst calls it "event-specific data". This is > quite a mouthful, so the code usually calls it "arguments". Not least > because events are kind of like commands going in the other direction > (client to server), and the code dealing with them is often similar. > > Both names make more sense to me than "member". Hmm. A rename could be > done as a follow-up if that's more convenient for you. > Also wish you'd have said sooner :) I might punt this one. At least, the next respin probably won't include this. I suppose I think about this in terms of "members of the event object." Let's talk and fix later, changing the name outside of a gigantic series is not difficult at all. > > > As per usual, QAPI cross-referencing for types in the member field list > > will be added in a forthcoming commit. > > > > Signed-off-by: John Snow <js...@redhat.com> > >
