On Tue, Mar 04, 2025 at 11:03:52PM +0100, Maciej S. Szmigiero wrote: > @@ -509,6 +513,9 @@ static void vfio_save_cleanup(void *opaque) > Error *local_err = NULL; > int ret; > > + /* Currently a NOP, done for symmetry with load_cleanup() */ > + vfio_multifd_cleanup(vbasedev);
So I just notice this when looking at the cleanup path. It can be super confusing to cleanup the load threads in save().. IIUC we should drop it. > + > /* > * Changing device state from STOP_COPY to STOP can take time. Do it > here, > * after migration has completed, so it won't increase downtime. -- Peter Xu
