Re: [PATCH v5 28/36] vfio/migration: Multifd device state transfer support - config loading support

[Maciej S. Szmigiero]

On 4.03.2025 08:41, Cédric Le Goater wrote:

@@ -728,6 +728,12 @@ static int vfio_load_state(QEMUFile *f, void *opaque, int 
version_id)
          switch (data) {
          case VFIO_MIG_FLAG_DEV_CONFIG_STATE:
          {
+            if (vfio_multifd_transfer_enabled(vbasedev)) {
+                error_report("%s: got DEV_CONFIG_STATE but doing multifd 
transfer",
+                             vbasedev->name);

To make clearer, maybe change to:
"%s: got DEV_CONFIG_STATE in main migration channel but doing multifd transfer"

That normally would be good idea, however we are already at 83 characters in 
this
line here and will not fit that many more words to this string.

The 80 characters "rule" is not strict. A clear error report is
always good to have !

Changed the message to the suggested by splitting that string into two to avoid 
going
above 100 characters per line.

Thanks,

C.

Thanks,
Maciej