Hi Nicolin, > -----Original Message----- > From: Nicolin Chen <nicol...@nvidia.com> > Sent: Thursday, February 6, 2025 6:58 PM > To: Shameerali Kolothum Thodi <shameerali.kolothum.th...@huawei.com> > Cc: Eric Auger <eric.au...@redhat.com>; ddut...@redhat.com; Peter > Maydell <peter.mayd...@linaro.org>; Jason Gunthorpe <j...@nvidia.com>; > Daniel P. Berrangé <berra...@redhat.com>; qemu-...@nongnu.org; > qemu-devel@nongnu.org; Linuxarm <linux...@huawei.com>; Wangzhou > (B) <wangzh...@hisilicon.com>; jiangkunkun <jiangkun...@huawei.com>; > Jonathan Cameron <jonathan.came...@huawei.com>; > zhangfei....@linaro.org > Subject: Re: [RFC PATCH 0/5] hw/arm/virt: Add support for user-creatable > nested SMMUv3 > [..]
> > One of the feedback I received on my series was to rename "arm-smmuv3- > nested" > > to "arm-smmuv3-accel" and possibly rename function names to include > "accel' as well > > and move those functions to a separate "smmuv3-accel.c" file. I suppose > that applies to > > the " Add HW accelerated nesting support for arm SMMUv3" series as > well. > > > > Is that fine with you? > > Oh, no problem. If you want to rename the whole thing, please feel > free. I do see the naming conflict between the "nested" stage and > the "nested" HW feature, which are both supported by the vSMMU now. I am working on the above now and have quick question to you😊. Looking at the smmu_dev_attach_viommu() fn here[0], it appears to do the following: 1. Alloc a s2_hwpt if not allocated already and attach it. 2. Allocate abort and bypass hwpt 3. Attach bypass hwpt. I didn't get why we are doing the step 3 here. To me it looks like, when we attach the s2_hwpt(ie, the nested parent domain attach), the kernel will do, arm_smmu_attach_dev() arm_smmu_make_s2_domain_ste() It appears through step 3, we achieve the same thing again. Or it is possible I missed something obvious here. Please let me know. Thanks, Shameer [0] https://github.com/nicolinc/qemu/blob/wip/for_shameer_02042025/hw/arm/smmu-common.c#L910C13-L910C35
