On 2/28/25 12:00, Chalapathi V wrote:
On 28-02-2025 13:15, Cédric Le Goater wrote:
On 2/28/25 04:03, Chalapathi V wrote:
On 27-02-2025 07:24, Nicholas Piggin wrote:
On Sat Jan 4, 2025 at 2:18 AM AEST, Chalapathi V wrote:
Create a spi buses with distict names on each socket so that responders
are attached to correct SPI controllers.
QOM tree on a 2 socket machine:
(qemu) info qom-tree
/machine (powernv10-machine)
/chip[0] (power10_v2.0-pnv-chip)
/pib_spic[0] (pnv-spi)
/chip0.pnv.spi.bus.0 (SSI)
/xscom-spi[0] (memory-region)
/chip[1] (power10_v2.0-pnv-chip)
/pib_spic[0] (pnv-spi)
/chip1.pnv.spi.bus.0 (SSI)
/xscom-spi[0] (memory-region)
Mechanics of the patch looks fine. I don't know about the name
though.
I think "pnv-spi-bus" is the right name for the bus. Using dots as
with chip0. makes it seem like each element is part of a topology.
Would chip0.pnv-spi-bus be better?
Will rename the bus name to chip0.pnv-spi-bus . Thank You
Yep. I don't think the bus suffix is useful (minor).
Will you be attaching flash devices from the command line ? Can you provide
an example if so ?
Thanks,
C.
Yes, I am attaching seeprom and TPM device from command line.
"-blockdev node-name=pib_spic2,driver=file,filename=%s -device
25csm04,bus=chip0.pnv-spi-bus.2,cs=0,drive=pib_spic2"
"-chardev socket,id=chrtpm,path=/tmp/swtpm.chalap1.250227212039.rOWBH/swtpm-sock
-tpmdev emulator,id=tpm0,chardev=chrtpm -device
tpm-tis-spi,tpmdev=tpm0,bus=chip0.pnv-spi-bus.4"
"chipX.spi.4" should be enough to identify the bus IMO.
Thanks,
C.
