Il 01/05/2012 22:46, Anthony Liguori ha scritto: >>> >>> >>> So I think we can safely break it :-) >> >> Does this work with compat properties set on a bus? > > No :-( > > This is pretty easy to fix though. The attached should do the trick, > I'll update and send out. > > Even if it does, >> perhaps it's better to avoid the cleverness and wait for my series that >> moves bus properties to the appropriate abstract superclass. > > This series does that FWIW (patch 6/14).
Yeah, it should---modulo bisectability of course. It's a fairly different approach WRT my series (using qdev_add_properties instead of klass->props). In theory I like it, but I fail to see right now whether it breaks "-device foo,?" somehow. I think it does: $ qemu-system-x86_64 -device rtl8139,? rtl8139.mac=macaddr rtl8139.vlan=vlan rtl8139.netdev=netdev rtl8139.bootindex=int32 rtl8139.addr=pci-devfn <<< here start bus props rtl8139.romfile=string rtl8139.rombar=uint32 rtl8139.multifunction=on/off rtl8139.command_serr_enable=on/off I think it's too late for this series to go into 1.1. Paolo
