Re: [PATCH 1/4] target/ppc: drop ppc_tlb_invalidate_all from cpu_reset

[Richard Henderson]

On 2/25/25 10:46, Alex Bennée wrote:

diff --git a/target/ppc/cpu_init.c b/target/ppc/cpu_init.c
index 062a6e85fb..f987b75c4f 100644
--- a/target/ppc/cpu_init.c
+++ b/target/ppc/cpu_init.c
@@ -7242,9 +7242,6 @@ static void ppc_cpu_reset_hold(Object *obj, ResetType 
type)
      if (tcg_enabled()) {
          cpu_breakpoint_remove_all(cs, BP_CPU);
          cpu_watchpoint_remove_all(cs, BP_CPU);
-        if (env->mmu_model != POWERPC_MMU_REAL) {
-            ppc_tlb_invalidate_all(env);
-        }
          pmu_mmcr01a_updated(env);
      }

Nack.  This is flushing the thing emulating the on-chip hardware, not the 
softmmu tlb.


r~