Richard Henderson <richard.hender...@linaro.org> writes:
> On 2/25/25 03:08, Alex Bennée wrote:
>> To move the main api.c to a single build compilation object we need to
>> start splitting out user and system specific code. As we need to grob
>> around host headers we move these particular helpers into the *-user
>> mode directories.
>> The binary/start/end/entry helpers are all NOPs for system mode.
>> Signed-off-by: Alex Bennée<alex.ben...@linaro.org>
>> ---
>> linux-user/plugin-api.c | 43 +++++++++++++++++++++++++++++++++++++++++
>> plugins/api-system.c | 39 +++++++++++++++++++++++++++++++++++++
>> plugins/api.c | 43 -----------------------------------------
>> linux-user/meson.build | 1 +
>> plugins/meson.build | 2 +-
>> 5 files changed, 84 insertions(+), 44 deletions(-)
>> create mode 100644 linux-user/plugin-api.c
>> create mode 100644 plugins/api-system.c
>
> Surely this breaks bsd-user.
It didn't seem to - but my local building isn't working so maybe CI
disables plugins.
>
> Ideally this would go in common-user, but I think you'd need to move
> structures out of {bsd,linux}-user/qemu.h into include/user/.
>
> In the very short term you could put plugin-api.c.inc in common-user, and
>
>
> #include "qemu.h"
> #include "common-user/plugin-api.c.inc"
>
>
> in both linux-user and bsd-user.
>
>
> r~
--
Alex Bennée
Virtualisation Tech Lead @ Linaro
