Hi Michael,
Thanks for looking at here!
On Thu, Feb 20, 2025 at 10:16:56AM -0500, Michael S. Tsirkin wrote:
> Date: Thu, 20 Feb 2025 10:16:56 -0500
> From: "Michael S. Tsirkin" <m...@redhat.com>
> Subject: Re: [PATCH RESEND] i386: Only configure HPET firmware info when
> HPET is enabled
>
> On Tue, Jan 21, 2025 at 10:01:21PM +0800, Zhao Liu wrote:
> > At present, the hpet_cfg is written unconditionally since 40ac17cd56eb
> > ("pass info about hpets to seabios.]"), because it concerns ACPI HPET is
> > created unconditionally.
> >
> > But that fact has changed since 51124bbfd2ea ("i386: acpi: Don't build
> > HPET ACPI entry if HPET is disabled") and ACPI checks if HPET device
> > exists in (hw/i386/acpi-build.c).
> >
> > Therefore, configure HPET firmware information if and only if HPET is
> > enabled.
> >
>
> and what is the gain from this change? just a cleanup?
This patch was trying to decouple hpet_cfw with i386 codes, which can
resolve the compilation issue when both the Rust and C versions of HPET
are both disabled.
But this patch is not needed since Paolo has figured out a simpler way
[*].
And thank you anyway!
[*]:
https://lore.kernel.org/qemu-devel/CABgObfb6PhiKO9=iwne9aoxq+ek7fddow8d0vcwvw3qa3tw...@mail.gmail.com/
Regards,
Zhao
