On 04/02/2025 21.10, Joel Granados wrote:
Replace the meson introspect argument with the build directory instead
of the meson.build file. The introspect command accepts an optional
build directory not a file.

Signed-off-by: Joel Granados <joel.grana...@kernel.org>
---
For some reason this causes an error when I "remote" compile qemu.
In any case, the introspect only accepts directories, so having it point
the to the meson.build file is a mistake.

Comments are greatly appreciated
---
  Makefile | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index b65b0bd41a..da88d9bb31 100644
--- a/Makefile
+++ b/Makefile
@@ -129,7 +129,7 @@ Makefile.mtest: build.ninja scripts/mtest2make.py
  .PHONY: update-buildoptions
  all update-buildoptions: $(SRC_PATH)/scripts/meson-buildoptions.sh
  $(SRC_PATH)/scripts/meson-buildoptions.sh: $(SRC_PATH)/meson_options.txt
-       $(MESON) introspect --buildoptions $(SRC_PATH)/meson.build | $(PYTHON) \
+       $(MESON) introspect --buildoptions $(BUILD_DIR) | $(PYTHON) \
          scripts/meson-buildoptions.py > $@.tmp && mv $@.tmp $@
  endif

Reviewed-by: Thomas Huth <th...@redhat.com>

I'll queue this patch for my next pull request, unless Paolo rather wants to take it.


Reply via email to