On Fri, 21 Feb 2025 at 13:08, Thomas Huth <th...@redhat.com> wrote:
>
> On 21/02/2025 13.54, Thomas Huth wrote:
> > diff --git a/tests/functional/test_arm_sx1.py b/tests/functional/
> > test_arm_sx1.py
> > --- a/tests/functional/test_arm_sx1.py
> > +++ b/tests/functional/test_arm_sx1.py
> > @@ -43,7 +43,8 @@ def test_arm_sx1_initrd(self):
> > self.vm.add_args('-append', f'kunit.enable=0 rdinit=/sbin/init
> > {self.CONSOLE_ARGS}')
> > self.vm.add_args('-no-reboot')
> > self.launch_kernel(zimage_path,
> > - initrd=initrd_path)
> > + initrd=initrd_path,
> > + wait_for='Boot successful')
> > self.vm.wait(timeout=60)
>
> Actually, thinking about this twice, this might even be a valid fix for your
> problem. Without waiting for a a string that signals a successful boot, the
> test was just firing up the guest kernel and then waiting for 60 seconds for
> the guest kernel to boot up and shut down again. If the boot is delayed for
> some reasons, these 60 seconds might still not be enough. So if we wait for
> a successful boot first before starting with the timeout, the 60 seconds
> afterwards should be enough for a successful shut down, I guess?
Doesn't that just shuffle the timeouts around? If it
takes ages for the "boot" part then it will hit the timeout in
the meson.build file.
I'm trying with just bumping all the per-test timeouts
in the sx1 test to 120s.
-- PMM
