On 20/2/25 11:07, Philippe Mathieu-Daudé wrote:
On 12/10/18 10:20, Daniel P. Berrangé wrote:
On Fri, Oct 12, 2018 at 02:22:06AM +0200, Philippe Mathieu-Daudé wrote:
Hi Paolo,
Here are the changes you suggested in
https://lists.gnu.org/archive/html/qemu-devel/2018-10/msg02294.html
chardev: Simplify IOWatchPoll::fd_can_read as a GSourceFunc
chardev: Assert backend's chr_can_read() is positive
chardev: Let chr_sync_read() use unsigned type
chardev: Let chr_write use unsigned type
chardev: Let IOReadHandler use unsigned type
chardev: Let IOCanReadHandler use unsigned type
chardev: Let qemu_chr_fe_* use unsigned type
chardev: Let qemu_chr_be_* use unsigned type
chardev: FDChardev::max_size be unsigned
s/unsigned/size_t/ in all these commit messages, as it looked
like you meant 'unsigned int' with the current commit msg.
Sure.
Paolo, any blocking comment before I fix the bitrotten places?
Doh, I just noticed your comments in the last patch:
https://lore.kernel.org/qemu-devel/786ca1d4-f874-e643-b85a-20652f1c8...@redhat.com/
