On 22:08 Wed 19 Feb , Philippe Mathieu-Daudé wrote:
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> While we model a 4-elements RX FIFO since the PL011 model
> was introduced in commit 20dcee94833 ("MCF5208 emulation"),
> we only read 1 char at a time!
"the MCF UART model"
Reviewed-by: Luc Michel <luc.mic...@amd.com>
>
> Have the IOCanReadHandler handler return how many elements are
> available, and use that in the IOReadHandler handler.
>
> Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>
> ---
> hw/char/mcf_uart.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/hw/char/mcf_uart.c b/hw/char/mcf_uart.c
> index 95f269ee9b7..529c26be93a 100644
> --- a/hw/char/mcf_uart.c
> +++ b/hw/char/mcf_uart.c
> @@ -281,14 +281,16 @@ static int mcf_uart_can_receive(void *opaque)
> {
> mcf_uart_state *s = (mcf_uart_state *)opaque;
>
> - return s->rx_enabled && (s->sr & MCF_UART_FFULL) == 0;
> + return s->rx_enabled ? FIFO_DEPTH - s->fifo_len : 0;
> }
>
> static void mcf_uart_receive(void *opaque, const uint8_t *buf, int size)
> {
> mcf_uart_state *s = (mcf_uart_state *)opaque;
>
> - mcf_uart_push_byte(s, buf[0]);
> + for (int i = 0; i < size; i++) {
> + mcf_uart_push_byte(s, buf[i]);
> + }
> }
>
> static const MemoryRegionOps mcf_uart_ops = {
> --
> 2.47.1
>
--
