On Wed, 19 Feb 2025 at 11:28, Paolo Bonzini <pbonz...@redhat.com> wrote:
> On Tue, Feb 18, 2025 at 3:55 PM Phil Dennis-Jordan <p...@philjordan.eu> > wrote: > > It is not cross-architecture. So, the PVG guest drivers with x86-64 > macOS don't > > give useful results with the aarch64 macOS host PVG framework. (I > suspect a > > mismatch in texture memory layout and perhaps some other data format > issues > > Apple's GPUs use a "swizzled" memory layout, whereas Intel/AMD/NVIDIA's > do not.) > > Thanks, that helps. > > > In summary, hw/display/apple-gfx-mmio.m has a hard dependency on aarch64 > *host* > > systems, and both apple-gfx device variants only make sense when host > arch matches > > guest arch. (Unless you're a developer attempting to find a workaround > to the > > incompatibility.) I'm very much not a Meson expert, so this was my best > attempt at > > encoding these facts in the build system. (And nobody suggested anything > better during > > review.) > > I'll find a way to do that, thanks. I also would prefer to add > --enable/--disable-pvg; I > can take care of that, but I just need to know... >> Either way, the Kconfig file does not need "depends on AARCH64" and it > >> should have just > >> > >> depends on MAC_PVG > >> > >> with an "imply" somewhere in hw/arm/Kconfig. > > ... which boards should enable MAC_PVG_MMIO? Is it only VIRT, or something > else? I doubt anyone will be able to use it productively with virt, but I am regularly surprised by people's creativity. The intended target machine is vmapple, which is the only known way to run aarch64 macOS guests. The PVG patches were part of that series, the PCI variant is useful independently of it though; Philippe said at one point early Jan/late Dec he was going to merge the rest of the patch series containing that machine type, but there were some question marks about the software GICv3 dependency and HVF I believe. I'll try to rebase that series and re-post it in the next few days - I've been too busy with another project to stay on top of chasing that down, but I'd really like to get it done for 10.0. Phil