On Wed, Feb 19, 2025 at 4:24 AM Markus Armbruster <arm...@redhat.com> wrote:
> Peter Xu <pet...@redhat.com> writes: > > > On Tue, Feb 18, 2025 at 10:39:55AM +0800, yong.hu...@smartx.com wrote: > >> From: Hyman Huang <yong.hu...@smartx.com> > >> > >> When the developer is examining the time distribution of > >> the migration, it is useful to record the migration throttle > >> timestamp. Consequently, include the migration throttle event. > > > > Would trace_cpu_throttle_set() work too? That can provide a timestamp > and > > also the new percentage of throttle. > > > > I don't feel strongly that we must not introduce qmp events for > debugging, > > but allowing that to happen means we can get tons of events at last.. as > > people can start requesting many more events, and we'll need one way to > > justify them at last. > > > > One way to justify events can be that it could be consumed by mgmt. On > > that, this one I'm not yet sure.. so ideally tracepoints could work > already. > > Good point. > > Ack -- Best regards
