On Mon, 17 Feb 2025 at 15:35, Peter Maydell <peter.mayd...@linaro.org> wrote: > /* If changing this, update the docs for highmem-mmio-size */ > #define DEFAULT_HIGH_PCIE_MMIO_SIZE_GB 512 > #define DEFAULT_HIGH_PCIE_MMIO_SIZE (DEFAULT_HIGH_PCIE_MMIO_SIZE_GB * GiB) > > and use it in the definition of extended_memmap[] and in > the "if (size < ...)" test for the "smaller than default" check. > > Have the error message say > "highmem_mmio_size cannot be set to a lower value than the default (%d > GiB)", > DEFAULT_HIGH_PCIE_MMIO_SIZE_GB
...or better, use size_to_str() from qemu/cutils.h, which will pretty-print a number into a human-readable form with a GiB or whatever suffix. thanks -- PMM
