On Sat, 8 Feb 2025 at 16:39, Philippe Mathieu-Daudé <phi...@linaro.org> wrote:
>
> Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>
> ---
> hw/char/pl011.c | 4 +++-
> hw/char/trace-events | 2 ++
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/hw/char/pl011.c b/hw/char/pl011.c
> index b9c9e5b5983..447f185e2d5 100644
> --- a/hw/char/pl011.c
> +++ b/hw/char/pl011.c
> @@ -148,6 +148,7 @@ static bool pl011_loopback_enabled(PL011State *s)
>
> static bool pl011_is_fifo_enabled(PL011State *s)
> {
> + trace_pl011_fifo_is_enabled((s->lcr & LCR_FEN) != 0);
> return (s->lcr & LCR_FEN) != 0;
Might be neater having a local variable rather than
repeating the expression twice.
Anyway
Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>
thanks
-- PMM
