On Thu, 6 Feb 2025 at 22:12, Hao Wu <wuhao...@google.com> wrote: > > Changes since v3: > > 1. Removed REGS_END constants according to code review. > 2. Added a few asserts according to code review. > 3. A few minor style changes. > > Changes since v2: > > 1. Update doc to include npcm845-evb description > 2. Add g_assert for register size in CLK and GCR enter_reset function > 3. Fix various 8xx SoC and board file issues. > > Changes since v1: > > 1. Updated vbootrom and pc-bios > 2. Split out CLK/GCR patches into refactoring and adding new features > 3. Fixed a few misc items from the patches.
I had a minor comment on patch 15, and as Philippe notes you need to bump the vmstate version number where you change the size of something that's a vmstate array field, but I think this is very close to being ready to go in. thanks -- PMM