Re: [PULL 23/27] i386: enable rust hpet for pc when rust is enabled

[Paolo Bonzini]

On 2/17/25 12:03, Zhao Liu wrote:

Hi Paolo,

--- a/hw/timer/Kconfig
+++ b/hw/timer/Kconfig
@@ -11,7 +11,7 @@ config A9_GTIMER

config HPET

      bool
-    default y if PC
+    default y if PC && !HAVE_RUST

+
+config X_HPET_RUST
+    bool
+    default y if PC && HAVE_RUST

  config I8254
      bool

This patch doesn't enable the configuration option of Rust HPET for PC.

Is it because the Rust HPET would break live migration, so we have to
disable it?

No, something like this is missing:

diff --git a/rust/hw/timer/Kconfig b/rust/hw/timer/Kconfig
index afd98033503..42e421317a5 100644
--- a/rust/hw/timer/Kconfig
+++ b/rust/hw/timer/Kconfig
@@ -1,2 +1,3 @@
 config X_HPET_RUST
     bool
+    default y if PC && HAVE_RUST

I haven't checked if this passes CI yet.

Paolo