On Mon, Feb 17, 2025 at 11:48:49AM +0100, Ilya Leoshkevich wrote: > Date: Mon, 17 Feb 2025 11:48:49 +0100 > From: Ilya Leoshkevich <i...@linux.ibm.com> > Subject: [PATCH] stub: Remove monitor-fd.c > X-Mailer: git-send-email 2.48.1 > > Both monitor-fd.c and monitor-internal.c contain a stub for > monitor_get_fd(), which causes a duplicate symbol linker error when > linking rust-qemu-api-integration. Use monitor-internal.c instead of > monitor-fd.c and remove the latter. > > Reported-by: Zhao Liu <zhao1....@intel.com> > Suggested-by: Zhao Liu <zhao1....@intel.com> > Fixes: fccb744f41c6 ("gdbstub: Try unlinking the unix socket before binding") > Signed-off-by: Ilya Leoshkevich <i...@linux.ibm.com> > --- > stubs/meson.build | 2 +- > stubs/monitor-fd.c | 9 --------- > 2 files changed, 1 insertion(+), 10 deletions(-) > delete mode 100644 stubs/monitor-fd.c
Thanks Ilya! LGTM, Reviewed-by: Zhao Liu <zhao1....@intel.com>