On 13/2/25 12:32, Daniel Henrique Barboza wrote:
On 2/13/25 4:52 AM, Clément Léger wrote:
As raised by Richard Henderson, these warnings are displayed in user
only as well. Disable them for CONFIG_USER_ONLY.
Signed-off-by: Clément Léger <cle...@rivosinc.com>
---
I'm second guessing having these warnings at all.
Sure they serve as a warning for us, developers, that something needs to
be revisited (e.g. after an OpenSBI update). However it will degrade user
experience with warnings related to something out of the user control.
Instead of adding CONFIG_USER_ONLY gates for these warnings I believe we're
better of removing them. We can add TODO/FIXME tags in the code if there's
something that we need to revisit at a later time.
You can also convert them to trace events, which are less invasive,
or warn_report(). But IIUC this case I agree a comment is good enough.
Thanks,
Daniel
target/riscv/tcg/tcg-cpu.c | 4 ++++
1 file changed, 4 insertions(+)
