On Mon, Feb 10, 2025 at 09:46:46AM +0100, David Hildenbrand wrote: > We want to pass another flag that will be stored in MemTxAttrs. So pass > MemTxAttrs directly. > > Reviewed-by: Peter Xu <pet...@redhat.com> > Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org> > Signed-off-by: David Hildenbrand <da...@redhat.com> > --- > hw/core/loader.c | 2 +- > hw/remote/vfio-user-obj.c | 2 +- > include/exec/memory.h | 5 +++-- > system/memory_ldst.c.inc | 18 +++++++++--------- > system/physmem.c | 12 ++++++------ > 5 files changed, 20 insertions(+), 19 deletions(-)
This breaks mac builds.. I'll squash: diff --git a/hw/display/apple-gfx.m b/hw/display/apple-gfx.m index aa1455b629..1554f3b801 100644 --- a/hw/display/apple-gfx.m +++ b/hw/display/apple-gfx.m @@ -137,7 +137,8 @@ static void apple_gfx_destroy_task(AppleGFXState *s, PGTask_t *task) MEMTXATTRS_UNSPECIFIED); if (!ram_region || ram_region_length < length || - !memory_access_is_direct(ram_region, !read_only)) { + !memory_access_is_direct(ram_region, !read_only, + MEMTXATTRS_UNSPECIFIED)) { return NULL; } -- Peter Xu