On 11/02/2025 19.53, Philippe Mathieu-Daudé wrote:
On 11/2/25 19:48, Philippe Mathieu-Daudé wrote:
On 11/2/25 19:26, Stefan Hajnoczi wrote:
On Mon, Feb 10, 2025 at 3:43 PM Philippe Mathieu-Daudé
<phi...@linaro.org> wrote:
The following changes since commit
54e91d1523b412b4cff7cb36c898fa9dc133e886:
Merge tag 'pull-qapi-2025-02-10-v2' of https://repo.or.cz/qemu/
armbru into staging (2025-02-10 10:47:31 -0500)
are available in the Git repository at:
https://github.com/philmd/qemu.git tags/hw-misc-20250210
for you to fetch changes up to 1078a376932cc1d1c501ee3643fef329da6a189a:
hw/net/smc91c111: Ignore attempt to pop from empty RX fifo
(2025-02-10 21:30:44 +0100)
----------------------------------------------------------------
Misc HW patches
- Use qemu_hexdump_line() in TPM backend (Philippe)
- Make various Xilinx devices endianness configurable (Philippe)
- Remove magic number in APIC (Phil)
- Disable thread-level cache topology (Zhao)
- Xen QOM style cleanups (Bernhard)
- Introduce TYPE_DYNAMIC_SYS_BUS_DEVICE (Philippe)
- Invert logic of machine no_sdcard flag (Philippe)
- Housekeeping in MicroBlaze functional tests (Philippe)
Please take a look at this CI failure:
https://gitlab.com/qemu-project/qemu/-/jobs/9106591368
Hmm I can not reproduce locally this error:
Exception: Asset cache is invalid and downloads disabled
OK, I could reproduce by blowing my cache away.
The problem seems in the "tests/functional: Have microblaze tests
inherit common parent class" patch, which does:
-class MicroblazeelMachine(QemuSystemTest):
+class MicroblazeLittleEndianMachine(MicroblazeMachine):
I presume, since MicroblazeLittleEndianMachine is no more a direct
child of QemuSystemTest, then the ASSET_IMAGE_* aren't automatically
downloaded.
I guess you could fix it with:
diff --git a/tests/functional/test_microblaze_s3adsp1800.py
b/tests/functional/test_microblaze_s3adsp1800.py
--- a/tests/functional/test_microblaze_s3adsp1800.py
+++ b/tests/functional/test_microblaze_s3adsp1800.py
@@ -57,6 +57,8 @@ def do_xmaton_le_test(self, machine):
class MicroblazeBigEndianMachine(MicroblazeMachine):
+ ASSET_IMAGE_BE = MicroblazeMachine.ASSET_IMAGE_BE
+
def test_microblaze_s3adsp1800_legacy_be(self):
self.do_ballerina_be_test('petalogix-s3adsp1800')
diff --git a/tests/functional/test_microblazeel_s3adsp1800.py
b/tests/functional/test_microblazeel_s3adsp1800.py
--- a/tests/functional/test_microblazeel_s3adsp1800.py
+++ b/tests/functional/test_microblazeel_s3adsp1800.py
@@ -13,6 +13,8 @@
class MicroblazeLittleEndianMachine(MicroblazeMachine):
+ ASSET_IMAGE_LE = MicroblazeMachine.ASSET_IMAGE_LE
+
def test_microblaze_s3adsp1800_legacy_le(self):
self.do_xmaton_le_test('petalogix-s3adsp1800')
(this still won't help with the strange 403 error ... maybe we have to
mirror the asset in another place now if the advent-calendar site does not
work reliably anymore...)
Thomas
