On Tue, Feb 04, 2025 at 05:27:17PM +1000, Gavin Shan wrote: > On 11/26/24 5:56 AM, Jean-Philippe Brucker wrote: > > All Realm IPA states are by default RIPAS_EMPTY, and accessing them in > > that state causes injection of synchronous exception. Either the loader > > or the guest needs to set IPA state to RIPAS_RAM before accessing it. > > Since a Linux guest needs all memory ready at boot [1], initialize it > > here. > > > > [1] https://docs.kernel.org/arch/arm64/booting.html > > > > https://lore.kernel.org/all/20241004144307.66199-12-steven.pr...@arm.com/ > > > > Signed-off-by: Jean-Philippe Brucker <jean-phili...@linaro.org> > > --- > > v2->v3: New: the Linux guest does not initialize RIPAS itself anymore, > > and expects the loader to do it. > > --- > > hw/arm/boot.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > I think the changes in this patch can be combined to the following one, > or move this after it. It logically to initialize guest's RAM covered > by PATCH[9]. I'm not sure if there is particular reasonable why we > don't do that.
If I understand correctly you mean I should merge patches 9 and 18, or at least bring them closer together in the series? I'd like to keep the hw/arm and target/arm changes in separate patches, because it's a nice way to have smaller patches and gives a clean commit message. But I could interleave the hw/arm and target/arm changes within the series (where it makes sense like here), it may be easier to review For now I pushed the reworked series to branch cca/latest https://git.codelinaro.org/linaro/dcap/qemu/-/tree/cca/latest Thanks, Jean > > PATCH[09/26] target/arm/kvm-rme: Initialize Realm memory
