> diff --git a/rust/hw/char/pl011/src/device_class.rs > b/rust/hw/char/pl011/src/device_class.rs > index 8a157a663fb..dbef93f6cb3 100644 > --- a/rust/hw/char/pl011/src/device_class.rs > +++ b/rust/hw/char/pl011/src/device_class.rs > @@ -12,7 +12,6 @@ > > use crate::device::{PL011Registers, PL011State}; > > -#[allow(clippy::missing_const_for_fn)]
It seems like a rebase nit since the commit 7d0520398f7f ("rust: prefer NonNull::new to assertions"), which is not worth an extra commit either. > extern "C" fn pl011_clock_needed(opaque: *mut c_void) -> bool { > let state = NonNull::new(opaque).unwrap().cast::<PL011State>(); > unsafe { state.as_ref().migrate_clock } Reviewed-by: Zhao Liu <zhao1....@intel.com>