On 05/02/2025 16.59, Daniel P. Berrangé wrote:
A number of fields are set at the class level on QemuBaseTest, even
though the exact same named field is then set at the object level
later in most cases.

Signed-off-by: Daniel P. Berrangé <berra...@redhat.com>
---
  tests/functional/qemu_test/testcase.py | 6 ------
  1 file changed, 6 deletions(-)

diff --git a/tests/functional/qemu_test/testcase.py 
b/tests/functional/qemu_test/testcase.py
index 574c1942f2..531d6393ad 100644
--- a/tests/functional/qemu_test/testcase.py
+++ b/tests/functional/qemu_test/testcase.py
@@ -33,12 +33,6 @@
class QemuBaseTest(unittest.TestCase): - arch = None
-
-    workdir = None
-    log = None
-    logdir = None

That's what you get when a Python ignorant like me tries to write object oriented Python code ;-) Thanks for cleaning up my mess!

Reviewed-by: Thomas Huth <th...@redhat.com>


Reply via email to