Re: [PATCH v3 16/17] hw/arm: Add NPCM845 Evaluation board

[Philippe Mathieu-Daudé]

On 6/2/25 02:31, Hao Wu wrote:

Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>
Signed-off-by: Hao Wu <wuhao...@google.com>
---
  hw/arm/meson.build       |   2 +-
  hw/arm/npcm8xx_boards.c  | 253 +++++++++++++++++++++++++++++++++++++++
  include/hw/arm/npcm8xx.h |  20 ++++
  3 files changed, 274 insertions(+), 1 deletion(-)
  create mode 100644 hw/arm/npcm8xx_boards.c

diff --git a/include/hw/arm/npcm8xx.h b/include/hw/arm/npcm8xx.h
index 1f7e3d8116..f465d1eeb5 100644
--- a/include/hw/arm/npcm8xx.h
+++ b/include/hw/arm/npcm8xx.h
@@ -52,6 +52,26 @@

#define NPCM8XX_NR_PWM_MODULES 3 +typedef struct NPCM8xxMachine {

+    MachineState        parent;

Please use docs/devel/style.rst recommendations:

'parent_obj'

<new line>

+    /*
+     * PWM fan splitter. each splitter connects to one PWM output and
+     * multiple MFT inputs.
+     */
+    SplitIRQ            fan_splitter[NPCM8XX_NR_PWM_MODULES *
+                                     NPCM7XX_PWM_PER_MODULE];
+} NPCM8xxMachine;
+
+
+typedef struct NPCM8xxMachineClass {
+    MachineClass        parent;

'parent_class'

+
+    const char          *soc_type;
+} NPCM8xxMachineClass;
+
+#define TYPE_NPCM8XX_MACHINE MACHINE_TYPE_NAME("npcm8xx")
+OBJECT_DECLARE_TYPE(NPCM8xxMachine, NPCM8xxMachineClass, NPCM8XX_MACHINE)
+
  typedef struct NPCM8xxState {
      DeviceState         parent;