marcandre.lur...@redhat.com writes:
> From: Marc-André Lureau <marcandre.lur...@redhat.com>
>
> Allow to set the number of audio samples per read/write to dbus.
>
> Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com>
> ---
> qapi/audio.json | 22 +++++++++++++++++++++-
> audio/dbusaudio.c | 21 ++++++++++++++++++---
> ui/dbus-display1.xml | 12 ++++++++++++
> 3 files changed, 51 insertions(+), 4 deletions(-)
>
> diff --git a/qapi/audio.json b/qapi/audio.json
> index 519697c0cd..dd5a58d13e 100644
> --- a/qapi/audio.json
> +++ b/qapi/audio.json
> @@ -65,6 +65,26 @@
> '*in': 'AudiodevPerDirectionOptions',
> '*out': 'AudiodevPerDirectionOptions' } }
>
> +##
> +# @AudiodevDBusOptions:
> +#
> +# Options of the D-Bus audio backend.
> +#
> +# @in: options of the capture stream
> +#
> +# @out: options of the playback stream
> +#
> +# @nsamples: set the number of samples per read/write calls (default to 480,
> +# 10ms at 48kHz).
Markup error. This is rendered like
"nsamples": "int" (optional)
set the number of samples per read/write calls (default to 480,
10ms at 48kHz).
Fix:
# @nsamples: set the number of samples per read/write calls
# (default to 480, 10ms at 48kHz).
I'm not sure I understand the parenthesis. I guess it means default
value is 480 samples per read/write call, which translates to 10ms when
sampling at 48kHz. Correct?
> +#
> +# Since: 10.0
> +##
> +{ 'struct': 'AudiodevDBusOptions',
> + 'data': {
> + '*in': 'AudiodevPerDirectionOptions',
> + '*out': 'AudiodevPerDirectionOptions',
> + '*nsamples': 'uint32'} }
> +
Could use 'base': 'AudiodevGenericOptions' instead of duplicating @in
and @out, but that would deviate from all the other AudiodevFOOOptions.
I agree with your decision.
> ##
> # @AudiodevAlsaPerDirectionOptions:
> #
> @@ -490,7 +510,7 @@
> 'if': 'CONFIG_AUDIO_ALSA' },
> 'coreaudio': { 'type': 'AudiodevCoreaudioOptions',
> 'if': 'CONFIG_AUDIO_COREAUDIO' },
> - 'dbus': { 'type': 'AudiodevGenericOptions',
> + 'dbus': { 'type': 'AudiodevDBusOptions',
> 'if': 'CONFIG_DBUS_DISPLAY' },
> 'dsound': { 'type': 'AudiodevDsoundOptions',
> 'if': 'CONFIG_AUDIO_DSOUND' },
[...]
