Philippe Mathieu-Daudé <phi...@linaro.org> writes: > On 24/1/25 17:22, Philippe Mathieu-Daudé wrote: >> On 23/1/25 02:22, Gustavo Romero wrote: >>> Add me as the maintainer for the ivshmem-pci.c device, the ivshmem >>> server, and the ivshmem client tool. Also, adjust remaining parts left >>> behind after ivshmem PCI device was renamed from ivshmem.c to >>> ivshmem-pci.c, like header files, Kconfig, docs, and build scripts. >>> >>> >>> Cheers, >>> Gustavo >>> >>> Gustavo Romero (2): >>> hw/misc/ivshmem-pci: Rename remaining parts for consistency >>> MAINTAINERS: Add me as the maintainer for ivshmem-pci >> Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org> >> and queued, thanks for volunteering! > > Failing to build: > > docs/specs/ivshmem-spec.rst:17:unknown document: '../system/devices/ivshmem' > ninja: build stopped: subcommand failed. > > docs/specs/ivshmem-spec.rst only mention PCI, so I could squash in the > first patch: > -- >8 -- > diff --git a/docs/specs/ivshmem-spec.rst b/docs/specs/ivshmem-spec.rst > index 2d8e80055b0..e326d024487 100644 > --- a/docs/specs/ivshmem-spec.rst > +++ b/docs/specs/ivshmem-spec.rst > @@ -17,3 +17,3 @@ get interrupted by its peers. > For information on configuring the ivshmem device on the QEMU > -command line, see :doc:`../system/devices/ivshmem`. > +command line, see :doc:`../system/devices/ivshmem-pci`. > --- > But then I wonder if this document shouldn't mention the flat > device. Since I'm unsure I'm dropping the series (patch 2 > depends on 1).
Simple oversight in PATCH 1. It renames docs/system/devices/ivshmem.rst to docs/system/devices/ivshmem-pci.rst without updating the reference in docs/specs/ivshmem-spec.rst. Surprisingly, this didn't fail for me in an incremental build, only in a full one.
