Re: [PULL 8/9] target/hppa: Implement space register hashing for 64-bit HP-UX

[Helge Deller]

On 1/30/25 20:06, Michael Tokarev wrote:

30.01.2025 16:29, del...@kernel.org wrote:

diff --git a/target/hppa/translate.c b/target/hppa/translate.c

+    if (ctx->is_pa20 && (a->dr == 2)) {
+        /* Update gva_offset_mask from the new value of %dr2 */
+        gen_helper_update_gva_offset_mask(tcg_env);
+        /* Exit to capture the new value for the next TB. */
+        ctx->base.is_jmp = DISAS_IAQ_N_STALE_EXIT;
+    }

This fails to build, it looks like:
../target/hppa/translate.c:4621:9: error: nested extern declaration of 
'gen_helper_update_gva_offset_mask' [-Werror=nested-externs]

Indeed... there was an
 #ifndef CONFIG_USER_ONLY
 #endif
missing...

Fixed in the new pull request.

Thanks!
Helge