On Thu, Jan 30, 2025 at 06:12:32PM +0100, Kevin Wolf wrote: > This allows querying from QMP (and also HMP) whether an image is > currently active or inactive (in the sense of BDRV_O_INACTIVE). > > Signed-off-by: Kevin Wolf <kw...@redhat.com> > ---
> +++ b/block/qapi.c > @@ -63,6 +63,7 @@ BlockDeviceInfo *bdrv_block_device_info(BlockBackend *blk, > info->file = g_strdup(bs->filename); > info->ro = bdrv_is_read_only(bs); > info->drv = g_strdup(bs->drv->format_name); > + info->active = !bdrv_is_inactive(bs); Lots of double-negatives - annoying, but I don't see a way around it, and I agree with your decision to make the public interface use the positive (active) rather than the negative (inactive), even though the negative is the unusual case. Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. Virtualization: qemu.org | libguestfs.org
