On Tue, 2025-01-21 at 15:04 +0800, Jamin Lin wrote: > The previous implementation set the "aspeed_intc_ops" struct, > containing read > and write callbacks, to be used when I/O is performed on the INTC > region. > Both "aspeed_intc_read" and "aspeed_intc_write" callback functions > were used > for INTC0 (CPU DIE). > > To support the INTC1 (I/O DIE) model, introduces a new "reg_ops" > class > attribute. This allows setting different memory region operations to > support > different INTC models.
Is there a reason not to make it a different type altogether? I'm not sure I like the idea of playing tricks with the memory ops. The timer model does something similar, but I was toying with the idea of removing that part of its implementation... Andrew
