On 28/1/25 13:41, BALATON Zoltan wrote:
On Tue, 28 Jan 2025, Harsh Prateek Bora wrote:
On 1/27/25 15:56, Philippe Mathieu-Daudé wrote:
Move the TCGCPUOps handlers to a new unit: tcg-excp_helper.c,
only built when TCG is selected.
Nice.
Just a thought - will the filename look better as excp_helper-tcg.c ?
That naming usually help developers when using tab completion.
Or maybe stick to either _ or - in the filename and not mix both in one
name? If you want to use -tcg or tcg- then also rename to excp-helper.
We already have a mix of _ and - names but at least try to be consistent
within one name.
Other targets use a sub-directory:
$ ls -1d target/*/tcg
target/arm/tcg
target/i386/tcg
target/loongarch/tcg
target/mips/tcg
target/riscv/tcg
target/s390x/tcg
I'm not interested in particular with this target and ready to work a
lot on it, this is why I went with a surgical approach.
Regards,
BALATON Zoltan
