Re: [PATCH 28/28] cpus: Remove CPUClass::has_work() handler

[Richard Henderson]

On 1/21/25 06:23, Philippe Mathieu-Daudé wrote:

diff --git a/hw/core/cpu-system.c b/hw/core/cpu-system.c
index 7b16bda2250..7f287984aa6 100644
--- a/hw/core/cpu-system.c
+++ b/hw/core/cpu-system.c
@@ -25,12 +25,8 @@

bool cpu_has_work(CPUState *cpu)

  {
-    if (cpu->cc->sysemu_ops->has_work) {
-        return cpu->cc->sysemu_ops->has_work(cpu);
-    }
-
-    g_assert(cpu->cc->has_work);
-    return cpu->cc->has_work(cpu);
+    g_assert(cpu->cc->sysemu_ops->has_work);
+    return cpu->cc->sysemu_ops->has_work(cpu);

Let's assert this once at startup, much like we do in tcg_exec_realizefn for 
TCGCPUOps.

Otherwise,
Reviewed-by: Richard Henderson <richard.hender...@linaro.org>


r~