On Jan 7 15:29, Wilfred Mallawa via wrote: > This header contains the transport encoding for an SPDM message that > uses the SPDM over Storage transport as defined by the DMTF DSP0286. > > Signed-off-by: Wilfred Mallawa <wilfred.mall...@wdc.com> > --- > include/system/spdm-socket.h | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/include/system/spdm-socket.h b/include/system/spdm-socket.h > index 2b7d03f82d..fc007e5b48 100644 > --- a/include/system/spdm-socket.h > +++ b/include/system/spdm-socket.h > @@ -88,6 +88,18 @@ bool spdm_socket_send(const int socket, uint32_t > socket_cmd, > */ > void spdm_socket_close(const int socket, uint32_t transport_type); > > +/* > + * Defines the transport encoding for SPDM, this information shall be passed > + * down to the SPDM server, when conforming to the SPDM over Storage standard > + * as defined by DSP0286. > + */ > +typedef struct QEMU_PACKED { > + uint8_t security_protocol; > + uint16_t security_protocol_specific; > + bool inc_512; > + uint32_t length; > +} StorageSpdmTransportHeader;
Does it make sense to pack a bool? Is this defined by the SPDM server in use? I can't find the definition of this header anywhere. > + > #define SPDM_SOCKET_COMMAND_NORMAL 0x0001 > #define SPDM_SOCKET_STORAGE_CMD_IF_SEND 0x0002 > #define SPDM_SOCKET_STORAGE_CMD_IF_RECV 0x0003 > -- > 2.47.1 > >
signature.asc
Description: PGP signature