John Snow <js...@redhat.com> writes: > On Wed, Dec 18, 2024, 5:58 AM Markus Armbruster <arm...@redhat.com> wrote: > >> John Snow <js...@redhat.com> writes: >> >> > This patch adds an explicit section tag to all QAPIDoc >> > sections. Members/Features are now explicitly tagged as such, with the >> > name now being stored in a dedicated "name" field (which qapidoc.py was >> > not actually using anyway.) >> > >> > WIP: Yeah, the difference between "tagged" and "untagged" sections is >> > now pretty poorly named, and explicitly giving "untagged" sections an >> > "UNTAGGED" tag is ... well, worse. but mechanically, this accomplishes >> > what I need for the series. >> > >> > Please suggest better naming conventions, keeping in mind that I >> > currently have plans for a future patch that splits the "UNTAGGED" tag >> > into "INTRO" and "DETAILS" tags. But, we still need a meta-name for the >> > category of sections that are "formerly known as untagged" but cannot be >> > called "freeform" because that name is used for the category of >> > docblocks that are not attached to an entity (but happens to be >> > comprised entirely of "formerly known as untagged" sections.) >> > >> > Signed-off-by: John Snow <js...@redhat.com> >> >> Doesn't pass 'make check' for me. Diff appended. It shows the error >> messages get worse. > > Whoops! My per-patch tester wasn't running make check, only linters and > build testing. I'll fix this, but please keep reviewing in the meantime. > > Apologies for the oversight.
No worries :)
