"Michael S. Tsirkin" <m...@redhat.com> writes: > On Sat, Jan 04, 2025 at 04:36:04PM +0900, Akihiko Odaki wrote: >> This series was spun off from: >> "[PATCH 0/3] virtio-net: Convert feature properties to OnOffAuto" >> (https://patchew.org/QEMU/20240714-auto-v3-0-e27401aab...@daynix.com/) >> >> Some features are not always available with vhost. Legacy features are >> not available with vp_vdpa in particular. virtio devices used to disable >> them when not available even if the corresponding properties were >> explicitly set to "on". >> >> QEMU already has OnOffAuto type, which includes the "auto" value to let >> it automatically decide the effective value. Convert feature properties >> to OnOffAuto and set them "auto" by default to utilize it. This allows >> QEMU to report an error if they are set "on" and the corresponding >> features are not available. >> >> Signed-off-by: Akihiko Odaki <akihiko.od...@daynix.com> >> --- >> Changes in v3: >> - Rebased. >> - Link to v2: >> https://lore.kernel.org/r/20241022-virtio-v2-0-b2394236e...@daynix.com >> >> Changes in v2: >> - Expanded the message of patch "qdev-properties: Accept bool for >> OnOffAuto". >> - Link to v1: >> https://lore.kernel.org/r/20241014-virtio-v1-0-e9ddf7a81...@daynix.com > > > Markus I think you had feedback on previous versions of this?
I'll reply to v4. Thanks!
