Re: [RFC PATCH 1/7] cpus: Restrict CPU_FOREACH_SAFE() to user emulation

[Daniel Henrique Barboza]

Perhaps add in the commit msg something like "it's only being used in
bsd-user and linux-user code"

On 1/6/25 5:02 PM, Philippe Mathieu-Daudé wrote:

Signed-off-by: Philippe Mathieu-Daudé <phi...@linaro.org>
---

Reviewed-by: Daniel Henrique Barboza <dbarb...@ventanamicro.com>

  include/hw/core/cpu.h | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h
index c3ca0babcb3..48d90f50a71 100644
--- a/include/hw/core/cpu.h
+++ b/include/hw/core/cpu.h
@@ -594,8 +594,11 @@ extern CPUTailQ cpus_queue;
  #define first_cpu        QTAILQ_FIRST_RCU(&cpus_queue)
  #define CPU_NEXT(cpu)    QTAILQ_NEXT_RCU(cpu, node)
  #define CPU_FOREACH(cpu) QTAILQ_FOREACH_RCU(cpu, &cpus_queue, node)
+
+#if defined(CONFIG_USER_ONLY)
  #define CPU_FOREACH_SAFE(cpu, next_cpu) \
      QTAILQ_FOREACH_SAFE_RCU(cpu, &cpus_queue, node, next_cpu)
+#endif

extern __thread CPUState *current_cpu;