Re: [PATCH v2 09/23] target/loongarch: Use target_ulong for CSR helpers

[Jiaxun Yang]

在2024年12月26日十二月 下午9:31，Richard Henderson写道：
[...]
>>   
>> -target_ulong helper_crc32c(target_ulong val, target_ulong m, uint64_t sz)
>> +target_ulong helper_crc32c(target_ulong val, target_ulong m, target_ulong 
>> sz)
>>   {
>>       uint8_t buf[8];
>>       target_ulong mask = ((sz * 8) == 64) ? -1ULL : ((1ULL << (sz * 8)) - 
>> 1);
>> 
>
> Changes to helper definitions, but not to the declarations.
>
> Is this patch a victim of incorrect splitting, or incorrect rebasing?

Aha, those pairs of definitions and declarations are inconsistent in
existing code.

I should reflect this in commit message.

Thanks
>
>
> r~

-- 
- Jiaxun