Re: [RFC 06/13] rust: add bindings for memattrs

[Zhao Liu]

On Sun, Dec 08, 2024 at 10:30:34AM +0100, Paolo Bonzini wrote:
> Date: Sun, 8 Dec 2024 10:30:34 +0100
> From: Paolo Bonzini <pbonz...@redhat.com>
> Subject: Re: [RFC 06/13] rust: add bindings for memattrs
> 
> Il sab 7 dic 2024, 10:21 Philippe Mathieu-Daudé <phi...@linaro.org> ha
> scritto:
> 
> > >> is still decently packed and simplifies things a lot.
> > >
> > > The old struct is 4 bytes, and the new one is 8 bytes. We do
> > > a lot of directly passing 'struct MemTxAttrs' arguments around
> > > as arguments to functions (i.e. not passing pointers to them),
> > > so increasing it in size is not completely free.
> >
> > Should we add a check to not pass 8 bytes?
> >
> >    QEMU_BUILD_BUG_ON(sizeof(MemTxAttrs) != sizeof(uint64_t));
> >
> 
> Yes, why not.
>

Thank you all! Will also include this in the followup clean-up patches.

Regards,
Zhao